The whole thing is obviously fucked up, but one thing that stuck out to me was this:
one of the translation of the word into german is “time note”
Technical names being oriented around specific localisations are one of my pet peeves. Particularly when I’m trying to explain something to an international colleague who doesn’t speak German and can’t find the relevant, unintuitively named objects. Bonus points when the name itself is in German.
The safety things were: check that the repository exists before calling it. If not exists create it.
I could see an argument here, depending on your business context, that a missing repository shouldn’t be a “silent” fail in order to catch potential data entry errors. If the assumption is that the folder will always be there, it might be worthwhile to throw if that assumption turns out to be false.
I had a “silent” fail logic built into one of my products that ended up heavily distorting the results when it eventually turned out that the input data was heavily skewed due to sloppy human work.
Of course, given the general situation, I assume that your solution was sensible in your case. The response of “shut up” doesn’t exactly sound like “there is a good reason we want this to fail if it isn’t there”.
Before trying to send a SQL Query to the Database, check that the connection is established and open.
Uhhhhh… So, like, basic SQL connection handling? And they took issue with that?
If ever anyone brings up the stereotype of Germans being hyper-accurate to the point of being anal, I think that company is the counterexample.
The whole thing is obviously fucked up, but one thing that stuck out to me was this:
Technical names being oriented around specific localisations are one of my pet peeves. Particularly when I’m trying to explain something to an international colleague who doesn’t speak German and can’t find the relevant, unintuitively named objects. Bonus points when the name itself is in German.
I could see an argument here, depending on your business context, that a missing repository shouldn’t be a “silent” fail in order to catch potential data entry errors. If the assumption is that the folder will always be there, it might be worthwhile to throw if that assumption turns out to be false.
I had a “silent” fail logic built into one of my products that ended up heavily distorting the results when it eventually turned out that the input data was heavily skewed due to sloppy human work.
Of course, given the general situation, I assume that your solution was sensible in your case. The response of “shut up” doesn’t exactly sound like “there is a good reason we want this to fail if it isn’t there”.
Uhhhhh… So, like, basic SQL connection handling? And they took issue with that?
If ever anyone brings up the stereotype of Germans being hyper-accurate to the point of being anal, I think that company is the counterexample.