• Pika@sh.itjust.works
    link
    fedilink
    English
    arrow-up
    11
    ·
    8 hours ago

    is it auto reject, or just doesn’t auto approve and leaves it open for manual review

    It seems weird that you can’t do a pr at all with 1000 line changes, any moderate size feature addition could hit that mark

    • kuhli@lemmy.dbzer0.com
      link
      fedilink
      arrow-up
      2
      ·
      4 hours ago

      Yeah, 1k is kinda a small limit but I get the logic, you can almost always break changes into smaller increments and not mass merge a mega PR that’s hard to review

      • Pika@sh.itjust.works
        link
        fedilink
        English
        arrow-up
        6
        ·
        edit-2
        7 hours ago

        for a new feature request? a PR isn’t a commit, it’s a set of commits which would add to the line change amount.

        Like even if you spread it out across 20 or 30 commits that’s still going to be the same line count.

        I guess you could push not yet functional or used code to lessen the line count change, but that seems in bad taste. I’ve always gone off the working repo should always be in build or clean state and a push or commit shouldn’t break that.